mattermost
[GH-744] Add --include-only-org-members flag for channel subscriptions
Summary
This PR adds --include-only-org-members flag for channel subscriptions
Ticket Link
Fixes https://github.com/mattermost/mattermost-plugin-github/issues/744
Hello @burakcakirel,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
@raghavaggarwal2308 can this be QA'd before merge?
Hii @burakcakirel @wiggin77 @raghavaggarwal2308 , I have tested this and the flag --include-only-org-members is not working and the user is getting the events triggered by non-member user for an organization. cc @Kshitij-Katiyar
@burakcakirel thank you for your submission. It looks like the --include-only-org-members is not passing our QA testing. Would you like to take a look?
Hey @wiggin77, it’s been a while since I worked on this, but let me take a look.
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
@burakcakirel Did you get a chance to look into the issue?
Unfortunately, not yet.
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!