Consider implementing subscriptions feature as a form/modal

[mickmister]

Currently the subscriptions feature is all in the slash command /github subscriptions add, loaded with some unclear options through slash command flags, in particular the flag named features.

For example:

/github subscriptions add mattermost/mattermost-plugin-github --features pulls,issues,label:"Help Wanted"

Description of the feature from the command's help text:

• /github subscriptions add owner[/repo] [flags] - Subscribe the current channel to receive notifications about opened pull requests and issues for an organization or repository
  • flags currently supported:
    • --features - a comma-delimited list of one or more of the following:
      • issues - includes new and closed issues
      • pulls - includes new and closed pull requests
      • pulls_merged - includes merged pull requests only
      • pulls_created - includes new pull requests only
      • pushes - includes pushes
      • creates - includes branch and tag creations
      • deletes - includes branch and tag deletions
      • issue_comments - includes new issue comments
      • issue_creations - includes new issues only
      • pull_reviews - includes pull request reviews
      • label:<labelname> - limit pull request and issue events to only this label. Must include pulls or issues in feature list when using a label.
      • Defaults to pulls,issues,creates,deletes
    • --exclude-org-member - events triggered by organization members will not be delivered (the GitHub organization config should be set, otherwise this flag has not effect)
    • --render-style - notifications will be delivered in the specified style (for example, the body of a pull request will not be displayed). Supported values are collapsed, skip-body or default (same as omitting the flag).

[mickmister]

@asaadmahmood I'm curious if you would be interested in discussing a design for this? I think this feature has slowly grown in scope, to the point where it may make sense to have a dedicated form instead of having the slash command continue to get more loaded with cryptic options

[raghavaggarwal2308]

@wiggin77 Can you please look into this and see if we need to implement this or not? If yes, can we get the UI designs for this

[wiggin77]

@esethna I suspect you'll want to wait until we get customer feedback after the release, but I wanted to get this on your radar. The proposal here is to replace the slash commands with a modal dialog. Any initial thoughts on this?

[esethna]

I can see a modal being useful here although I imagine this would fall to the backlog for design given other priorities at the moment. We could open a ticket to track it in the mean time.