mattermost-plugin-github icon indicating copy to clipboard operation
mattermost-plugin-github copied to clipboard

[MM-356] Add feature to subscribe to release and workflow events

Open ayusht2810 opened this issue 1 year ago • 6 comments

Summary

  • Added feature to publish workflow failure events

Screenshot

image

Ticket Link

Fixes #722 Fixes #565

What to test?

  • Update the webhook for the repo to receive notifications for workflow events
  • Create a subscription for a repo with a subscription enabled for workflow events
  • Create workflow in which a particular jobs fail
  • Check for the event received in the subscribed channel

Checklist

  • [x] Completed dev testing
  • [x] make test Ran test cases and ensured they are passing
  • [x] make check-style Ran style check and ensured both webapp and server pass the checks

ayusht2810 avatar Apr 08 '24 13:04 ayusht2810

@mickmister Fixed the comments, Please have a look.

Kshitij-Katiyar avatar Jun 25 '24 11:06 Kshitij-Katiyar

This PR is going to have a significant merge conflict with https://github.com/mattermost/mattermost-plugin-github/pull/808/files

Does anyone have an opinion on which is more important?: release and workflow subscriptions vs discussions and comment

wiggin77 avatar Aug 01 '24 14:08 wiggin77

@wiggin77 In both the PRs we mainly adding new functions not updating the existing functions much. I think it won't be difficult to fix the conflicts in this case. So, we can merge whichever PR is ready first. Please let me know your opinions on this.

raghavaggarwal2308 avatar Aug 06 '24 09:08 raghavaggarwal2308

@wiggin77 In both the PRs we mainly adding new functions not updating the existing functions much. I think it won't be difficult to fix the conflicts in this case. So, we can merge whichever PR is ready first. Please let me know your opinions on this.

Ok, let's get this one merged first.

wiggin77 avatar Aug 06 '24 18:08 wiggin77

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar Sep 22 '24 01:09 mattermost-build

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar Oct 08 '24 01:10 mattermost-build