mattermost-plugin-github icon indicating copy to clipboard operation
mattermost-plugin-github copied to clipboard

Conflicting behavior with `UsePreregisteredApplication` and `EnterpriseBaseURL` config settings

Open mickmister opened this issue 3 years ago • 0 comments

At the moment, the plugin ignores the EnterpriseBaseURL setting if UsePreregisteredApplication is set to true. The UsePreregisteredApplication setting's description is currently:

When true, instructs the plugin to use the preregistered GitHub OAuth application - application registration steps can be skipped. Requires Chimera Proxy URL to be configured for the server. Cannot be used with GitHub enterprise. This setting is intended to be used with Mattermost Cloud instances only.

A customer ran into this issue that is both on Cloud and using GitHub Enterprise. We should make it clearer that this setting cannot be used with GitHub enterprise. Maybe begin the description with "Set to false if using GitHub Enterprise".

mickmister avatar Aug 04 '22 19:08 mickmister