mattermost-plugin-github icon indicating copy to clipboard operation
mattermost-plugin-github copied to clipboard

User gets unfriendly validation when GitHub domain is uppercase.

Open DHaussermann opened this issue 4 years ago • 2 comments

When trying to create a subscription where the GitHub domain is in uppercase letters the user gets an invalid / unfriendly validation issue.
image

Steps:

  • Install GitHub and connect a test user
  • Post /github subscriptions add https://GITHUB.COM/DHAUSSERMANN/HELLO-WORLD Observed: Unknown organization https: Expected: Not sure this is something that must work but, the validation message should not mention Unknown organization https: Ideally we would support this or inform the user the URL is the issue.

DHaussermann avatar Sep 21 '21 15:09 DHaussermann

@DHaussermann The error Unknown organization https: is unrelated to the uppercase issue. The expected input here would be only DHaussermann/hello-world, and not the full URL. 1/5 we should support pasting the repo's full URL as you've attempted here.

Going to https://github.com/dhaussermann (no uppercase letters), GitHub takes me to the right page. Maybe the GitHub entities are case insensitive. That would require some investigation to determine.

mickmister avatar Sep 21 '21 15:09 mickmister

Add @DHaussermann to detail the lack of support(?) for full Urls?

catalintomai avatar Sep 27 '21 19:09 catalintomai

@DHaussermann @mickmister From the discussion above and from the https://github.com/mattermost/mattermost-plugin-github/issues/501. Should we close this issue?

Kshitij-Katiyar avatar Oct 05 '23 10:10 Kshitij-Katiyar

@Kshitij-Katiyar Yeah I think we can close. No need to support all caps URL imo, in case we are currently not supporting that

mickmister avatar Oct 10 '23 04:10 mickmister