mattermost-plugin-github icon indicating copy to clipboard operation
mattermost-plugin-github copied to clipboard

This plugin failed to start. Check your system logs for errors.

Open jidl-gh opened this issue 4 years ago • 7 comments

I've gone through the prcoess of adding an OAuth client to github, entered the client ID and secret to the plugin config.

I can't seem to get the plugin to start though. I get the message:

This plugin failed to start. Check your system logs for errors.

As far as I can see the logs aren't availabe on the Mattermost cloud version.

The plugin version is 2.0.0. Any ideas?

jidl-gh avatar Mar 28 '21 16:03 jidl-gh

@jidl-gh Did you followed the steps at https://github.com/mattermost/mattermost-plugin-github#configuration before starting the plugin?

hanzei avatar Mar 29 '21 09:03 hanzei

I did. But the Step 6 failed:

Once you have successfully registered the Mattermost GitHub Plugin as an authorized OAuth app, switch to Mattermost and run /github connect in a Mattermost channel. You should receive a DM from the GitHub plugin about the features you have available.

Which led me to investigate further and see that the plugin doesn't start.

Does the starting of the plugin depend on a connection to the OAuth app? Or should it start regardless?

jidl-gh avatar Mar 29 '21 09:03 jidl-gh

@hanzei Maybe we should reconsider how we handle the non-configured state of the plugin. Instead of aborting the startup, we could have the plugin in an "inactive" state while still running. We would also need to provide feedback when the credentials are updated or some way of affirming that the plugin is correctly set up. This would be a much better experience for this situation where admins that can't access the logs.

mickmister avatar Mar 29 '21 14:03 mickmister

@jidl-gh Do you mind sending me a DM with your workspace URL on https://community.mattermost.com at @michael.kochell? I will try and see what's going on with the logs.

mickmister avatar Mar 29 '21 14:03 mickmister

Also can you please try restarting the plugin after setting the credentials if you haven't already?

mickmister avatar Mar 29 '21 14:03 mickmister

@hanzei Maybe we should reconsider how we handle the non-configured state of the plugin. Instead of aborting the startup, we could have the plugin in an "inactive" state while still running. We would also need to provide feedback when the credentials are updated or some way of affirming that the plugin is correctly set up. This would be a much better experience for this situation where admins that can't access the logs.

Great suggestion :+1: Would you be open on cutting a HW- ticket for that?

hanzei avatar Mar 29 '21 17:03 hanzei

HW ticket https://github.com/mattermost/mattermost-plugin-github/issues/432

mickmister avatar Apr 07 '21 20:04 mickmister