mattermost-plugin-github icon indicating copy to clipboard operation
mattermost-plugin-github copied to clipboard

Notification numbers are not properly aligned

Open agarciamontoro opened this issue 4 years ago • 7 comments

The numbers in the left hand side bar are not properly aligned, which is very obvious when all the numbers are the same ones, as in the following screenshot:

image

We need to fix the CSS so they are aligned. I'm not sure if the best way would be to assign the same width to the icons, or to align the icons and the numbers separately.

agarciamontoro avatar Oct 21 '20 09:10 agarciamontoro

I would love to work on this

RabsonJ avatar Oct 21 '20 09:10 RabsonJ

Awesome, thanks @RabsonJ :+1:

hanzei avatar Oct 21 '20 09:10 hanzei

Awesome, thanks @RabsonJ :+1:

Thank you! Let me get working

RabsonJ avatar Oct 21 '20 10:10 RabsonJ

@hanzei can you please give me the exact name of the file / it's location

RabsonJ avatar Oct 21 '20 10:10 RabsonJ

Sure @RabsonJ. The button are defined in https://github.com/mattermost/mattermost-plugin-github/blob/master/webapp/src/components/sidebar_buttons/sidebar_buttons.jsx. You might want to take a look at the getStyle method first: https://github.com/mattermost/mattermost-plugin-github/blob/793631adb358f29a7d1a187dfedd13c2d5dfdf11/webapp/src/components/sidebar_buttons/sidebar_buttons.jsx#L211-L235

hanzei avatar Oct 21 '20 10:10 hanzei

I would Like to work on this issue .

JanumalaAkhilendra avatar Feb 16 '24 17:02 JanumalaAkhilendra

Go ahead, @JanumalaAkhilendra, all yours!

agarciamontoro avatar Feb 16 '24 17:02 agarciamontoro