mattermost-plugin-github icon indicating copy to clipboard operation
mattermost-plugin-github copied to clipboard

Validate syntax when a subscription has an invalid label

Open DHaussermann opened this issue 5 years ago • 4 comments

If a user mistakenly forgets the " on the label, the label has no affect and it's not obvious why.

Ideally we can prevent this by checking if label: is followed by a value in quotes to prevent user error. If we showed a message such as no valid label provided this would be far more forgiving.

Steps:

  • type /github subscribe DHaussermann/hello-world pulls,issues,creates,deletes,label:Apples with Apples instead of "Apples"
  • Subscription successful

Observed Label has no affect as no valid label was provided

DHaussermann avatar Oct 07 '20 20:10 DHaussermann

@hanzei please advise if this is technically possible and would make a good help wanted.

DHaussermann avatar Oct 07 '20 20:10 DHaussermann

That improvement makes up for a great HW :+1:

hanzei avatar Oct 08 '20 09:10 hanzei

@DHaussermann @hanzei Hi, I would like to assign this issue to myself, and give it a try.

NamrataSitlani avatar Oct 08 '20 20:10 NamrataSitlani

Awesome, thanks for taking a look @NamrataSitlani. Let me know if you have any questions.

hanzei avatar Oct 08 '20 20:10 hanzei