mattermost-operator
mattermost-operator copied to clipboard
feat(ingress): aws alb
TODO:
- [x] Add tests
Summary
Add option for AWS ALB Ingress
See:
- https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.4/
- https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.4/guide/ingress/annotations/
Issue Link
Fixes #293
API
apiVersion: installation.mattermost.com/v1beta1
kind: Mattermost
metadata:
name: mm-example-full # Chose the desired name
spec:
size: 5000users # Adjust to your requirements
awsLoadBalancerController:
enabled: true
hosts:
- hostName: 'asd.example.com'
certificateARN: 'asdasd'
internetFacing: true
version: 6.0.1
licenseSecret: ""
Release Note
Adds an option to configure an AWS ALB instead of the default Nginx Ingress
Hello @Hunter-Thompson,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla
and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.
/check-cla
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
Hey @Hunter-Thompson, just checking in to see if you are still working on this PR. We have been keeping an eye on it while you have had it opened as a draft. Let us know if you want to chat about anything regarding this functionality. Thanks!
@gabrieljackson went away for awhile. Il be working on it this week.
Quick question, has apis/mattermost/v1alpha1
been deprecated in favor of apis/mattermost/v1beta1
?
Do I have to make changes in both places or is v1beta1
fine?
Hey @Hunter-Thompson, yes only updating v1beta
is fine here. v1alpha
is deprecated as you mentioned.
Let us know if you need any additional support with this.
@gabrieljackson could you have a look at the API and let me know if youd like changes? If no changes are required - Il start writing unit tests.
@gabrieljackson I've made the changes proposed. If the API looks good, I can start testing in my local Kubernetes cluster and also write unit tests.
@fmartingr, thanks for review. Ive pushed a new commit addressing some of the points. Il start working on better tests soon.
@fmartingr, thanks for review. Ive pushed a new commit addressing some of the points. Il start working on better tests soon.
Awesome, thanks! Just re-request my review or ping me once you're done so I can take a look :)
@fmartingr, thanks for review. Ive pushed a new commit addressing some of the points. Il start working on better tests soon.
Awesome, thanks! Just re-request my review or ping me once you're done so I can take a look :)
@fmartingr, I changed the tests a bit, and added a few new ones.
It covers:
- disable aws lb and enable aws lb
- check if resources are deleted properly after enabling and disabling
Could you review?
Did you get a chance to review @gabrieljackson?
bump
Hey @mirshahriar, since Gabe is pretty busy, would you mind taking a look at this?
Hey @mirshahriar, since Gabe is pretty busy, would you mind taking a look at this?
I'll have a look today.