mattermost-integration-gitlab icon indicating copy to clipboard operation
mattermost-integration-gitlab copied to clipboard

Published 20 hours ago • verified publisher icon mattermost

username link on issue comments

Open kaos opened this issue 10 years ago • 6 comments

seems to always point at gitlab.com/u/...

kaos avatar Nov 04 '15 16:11 kaos

Looks like the user url is not in the sent data (https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/web_hooks/web_hooks.md), it will have to be built by extracting the root url from one of the urls sent by the webhook.

NotSqrt avatar Nov 04 '15 17:11 NotSqrt

Yep, that would be the fix :)

kaos avatar Nov 05 '15 08:11 kaos

Yes, I can work on a fix for this in a day or say unless someone else wants to submit a PR for it :)

jwilander avatar Nov 05 '15 13:11 jwilander

I wouldn't mind submitting a PR, but haven't got the time right now...

kaos avatar Nov 05 '15 13:11 kaos

I might look into it, and also on #8 , since I'm the one that reported it :smiley:

NotSqrt avatar Nov 05 '15 13:11 NotSqrt

Done in my repository.

NotSqrt avatar Jan 19 '16 10:01 NotSqrt