mattermost-helm icon indicating copy to clipboard operation
mattermost-helm copied to clipboard

#387 Support imagePullSecrets in mattermost-enterprise-edition

Open yeongeon opened this issue 2 years ago • 2 comments

Summary

imagePullSecrets needs in mattermost-enterprise-edition helm chart for more convenience as below.

    spec:
      container:
      ...
      {{- with .Values.mattermostApp.image.imagePullSecrets }}
      imagePullSecrets:
        {{- toYaml . | nindent 8 }}
      {{- end }}

thus it edited three parts of templates,

  • deployment-mattermost-app.yaml
  • deployment-mattermost-jobserver.yaml
  • deployment-mattermost-loadtest.yaml

and it referred to the Kubernetes docs.

Ticket Link

Fixes https://github.com/mattermost/mattermost-helm/issues/387

yeongeon avatar Feb 13 '23 11:02 yeongeon

Hello @yeongeon,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

mattermost-build avatar Feb 13 '23 11:02 mattermost-build

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar Feb 28 '23 01:02 mattermost-build