mattermost-helm icon indicating copy to clipboard operation
mattermost-helm copied to clipboard

Fixing Ingress support for k8s >v1.18

Open maxirus opened this issue 2 years ago • 6 comments

Summary

Adds ingressClassName support.

Ticket Link

Fixes issue #337

maxirus avatar May 24 '22 21:05 maxirus

Hello @maxirus,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

mattermod avatar May 24 '22 21:05 mattermod

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Jun 04 '22 01:06 mattermod

Let's get this merged! :-)

hcsaustrup avatar Oct 25 '22 09:10 hcsaustrup

We're really looking forward to this feature. :) Is there anything were I can help to get this merged?

mjka-sclable avatar Nov 14 '22 15:11 mjka-sclable

@maxirus could you sign the CLA? @hcsaustrup Is there anything we can do to have this merged? If we want to deploy mattermost in a cluster and we want to use a non-default ingress, at this point we need to deploy the Ingress using an additional manifest

pablo-suazo avatar Feb 16 '23 16:02 pablo-suazo

@maxirus could you sign the CLA? @hcsaustrup Is there anything we can do to have this merged? If we want to deploy mattermost in a cluster and we want to use a non-default ingress, at this point we need to deploy the Ingress using an additional manifest

Sorry, I do not sign CLAs that require PII as a condition of an OSS contribution. That said, I give anyone else permission to copy my changes and submit them as their own if they wish.

maxirus avatar Feb 16 '23 18:02 maxirus