mattermost-helm icon indicating copy to clipboard operation
mattermost-helm copied to clipboard

Published 20 hours ago • verified publisher icon mattermost

fix-extraEnv-default-value

Open ruckc opened this issue 2 years ago • 9 comments

Summary

I messed up the default value for extraEnv in #316. This fixes the jobserver.extraEnv to be an array, which is what the template is expecting

Without this change, if trying to use jobserver's extraEnvs, you get this error:

cannot overwrite table with non table for mattermost-enterprise-edition.global.features.jobserver.extraEnv

ruckc avatar Apr 19 '22 21:04 ruckc

Hello @ruckc,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Apr 19 '22 21:04 mattermod

the tests need to be retried

ruckc avatar Apr 20 '22 00:04 ruckc

@spirosoik / @pfltdv / @stylianosrigas - can you review?

ruckc avatar Apr 29 '22 20:04 ruckc

@pfltdv did you give a try to test locally?

spirosoik avatar May 10 '22 06:05 spirosoik

@pfltdv did you give a try to test locally?

@spirosoik Yes tested with and without jobserver extra vars. Had no issue at both executions.

ghost avatar May 10 '22 07:05 ghost

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar May 21 '22 01:05 mattermod

@ruckc any reason this wasn't merged / updated anymore? Just saw that i've just create a PR for the same issue.

jonathanwiemers avatar Jul 11 '22 13:07 jonathanwiemers

@jonathanwiemers - no real reason, other than the 3 week lag on feedback. My need for this was removed as we moved away from mattermost due to the integration and license headaches.

ruckc avatar Jul 11 '22 14:07 ruckc

/update-branch

spirosoik avatar Sep 15 '22 05:09 spirosoik