mattermost-developer-documentation
mattermost-developer-documentation copied to clipboard
mattermost
Add project_id to Android sign script
Summary
Added project_id to be replaced in the strings resources as is needed by Firebase Cloud Messaging to be able to initialize and retrieve the device token to receive notifications.
Newest code from enahum has been published to preview environment for Git SHA 88cbc6bcf709a856d211fd6fda93d3a2429322c5
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Newest code from enahum has been published to preview environment for Git SHA 88cbc6bcf709a856d211fd6fda93d3a2429322c5
OOOO... nice fix for the ZIPALIGNER APKSIGNER issue too!
I'll download this, sign an unsigned bundle, and test... I've done it once, but will use the published version to QA this.
Okay, test checks out.
Only question I have is how do we handle the fact that the google-services.json file I get from Firebase is missing the firebase_url property...
I can't see a way for firebase to provide this? Is it possible we could just form the firebase_database_url property we inject into string.xml ourselves, so customers dont' have to add it? Does our app code care about this property, or is it in the underlying SDKs/etc.?
@enahum
I will take a stab at this. I'm still puzzled about why we don't get the firebase_url property in google-services.json. I mentioned in an SO comment.
Although, now that I think about it, if the full end to end build process still works then maybe the Google Services Maven plugin has already been updated to handle this 🤷🏼♂️?
Newest code from sadohert has been published to preview environment for Git SHA b53ed52dca27dfd1be6d8d83c9d415e2769e48c7
Newest code from enahum has been published to preview environment for Git SHA 93322ec5c9e3cce1122bb4375d3c2eb448324c82
Newest code from hanzei has been published to preview environment for Git SHA 7e9c8ef8eb44e8c2708645263dc85b6fad68b54f
Newest code from cwarnermm has been published to preview environment for Git SHA aa157f38dbf21c6e6ad865377d80583f05220158
@sadohert - Friendly ping on this PR. Please note that a second reviewer is required for this repository.
Hey - Apologies.. I didnt' know I still had to do something here.
@enahum how relevant is all this with Gekidou?
Newest code from cwarnermm has been published to preview environment for Git SHA 0bd854876e6e66c924865785a95613581180e54e
Newest code from cwarnermm has been published to preview environment for Git SHA 85b8cad600e906edd51e1b4860daa3e4a2b7a8c3
Newest code from cwarnermm has been published to preview environment for Git SHA 54831c5ee09a4eea66d96a80c056c39935308231
Newest code from cwarnermm has been published to preview environment for Git SHA 813ef90ac4203c613eea6d72b5c316b1cae6cb93
Newest code from cwarnermm has been published to preview environment for Git SHA f14c8b0efbe5b1628482869529b6088b5cd55af6
@cwarnermm I'm not likely to get to this for a while, but I also don't want to lose the change if it comes up again with another customer (hard to know when this will rear its head).... is there a place this PR can sit that isn't in the way, but isn't gone for good?
Newest code from cwarnermm has been published to preview environment for Git SHA 82f017a4cc056c38ac0b745254729fb7740eead8
Newest code from hanzei has been published to preview environment for Git SHA 1032b94be20bc5823fde6a1ca5b04a0d5609e9b6