focalboard
focalboard copied to clipboard
mattermost
[GH-533] fFix bug : Filter menu does not disappear when clicked for a second time (Board > Filter)
Hello @AbdelilahRami,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.
Hi @AbdelilahRami, please fill in your details after reading the Mattermost contribution license agreement. Once filled and submitted, comment /check-cla on this issue. Hope this helps:)
The package-lock.json file changes are not needed and actually are changing that to a previous version, do you mind to revert that?
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook
Trying to clean up stale PRs. @jespino, what is the next step here? Are there still changes required? Or can those be fixed later? Thanks.
@chenilim I was waiting for @AbdelilahRami explanation about the unregistering of the handler.