focalboard icon indicating copy to clipboard operation
focalboard copied to clipboard

Fix tooltip cutoff

Open redhoyasa opened this issue 2 years ago • 7 comments

Summary

Fix the kanban card tooltip that cutting off. I consider the both tooltip with short text and long text.

Before After
Screen Shot 2021-10-23 at 13 14 38 Screen Shot 2021-10-23 at 13 15 58

Ticket Link

Fix https://github.com/mattermost/focalboard/issues/3246.

redhoyasa avatar Oct 28 '22 09:10 redhoyasa

Hello @redhoyasa,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Oct 28 '22 09:10 mattermod

Hi @redhoyasa, it seems that proposed fix changes tooltip for all cards, even in the second column of kanban board: before applying the fix it looks like this:

kamre avatar Oct 30 '22 12:10 kamre

@kamre thanks for the feedback. I try to make some changes. Does it look good to you?

Screenshot 2022-10-31 at 4 33 42 PM

redhoyasa avatar Oct 31 '22 09:10 redhoyasa

@redhoyasa this definitely looks better.

@asaadmahmood what do you think about such changes to tooltip?

kamre avatar Oct 31 '22 10:10 kamre

@kamre @redhoyasa I think those look good, but it wouldn't make sense to always have the tip on the left. If we can make the tip position dynamic, like center, left, or right depending on the space available, that would be much better.

Otherwise, I don't want to change all tooltips to have the tip on the bottom left.

asaadmahmood avatar Oct 31 '22 10:10 asaadmahmood

@asaadmahmood @kamre that makes sense. Depending on available space could work but I'd like to propose something like this:

  1. For card within the left most list, the position would be on left
  2. For card within the right most list, the position would be on right
  3. Otherwise, the tooltip will be on the center

I think that way is easier to reason, what do you think?

redhoyasa avatar Nov 01 '22 02:11 redhoyasa

@redhoyasa That can be done though important to note that it's not always about the left most or right most list. It can be any list, as we allow scrolling.

So imagine you have 12 lists, and you hoirzontally scroll, so now the 3rd or 4th list can be the first list (visually speaking).

So even if we do it, it should focus more on the list position visually rather than its order.

asaadmahmood avatar Nov 01 '22 07:11 asaadmahmood

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Nov 13 '22 01:11 mattermod