focalboard
focalboard copied to clipboard
Bug: infinite error redirect loop
Steps to reproduce the behavior
- Go to a board with a view that causes an error
Boards: Sprints
in https://boards-bugbash73.test.mattermost.cloud/boards/team/emkcjitr1jfs5nzhntbj6dzztr/bcic7hnpf1bnf8x9b6hnxqhqmpc/v51b4fn1f7brfxkfk49cwzzndnr - Attempt to select the same error view again
- Observe error redirect loop (1+ minute)
Expected behavior
Not stuck in error redirect loop.
Screenshots (optional)
https://user-images.githubusercontent.com/6335792/189202768-6db8d989-cb59-4a87-a141-59698e4dd547.mov
Edition and Platform
- Edition: Mattermost Boards (plugin)
- Version: bugbash 7.3
- Browser and OS: FF105 Mac
Additional context (optional)
Add any other context about the problem here, and any notes about the severity:
- Sev 1: Affects critical functionality without a workaround
- Sev 2: Affects major functionality with a difficult or non-obvious workaround
- Sev 3: Affects minor, non-critical functionality
May be happening on community as well: https://community.mattermost.com/private-core/pl/humyg56q87g7brrx9uboqtj8dh
@wuwinson @Pinjasaur this was fixed by #3793 I've uploaded lagtest 7.3 with the patch on bugbashs server. Please give it a go.
Just did some testing and it appears resolved. My concern is still that our error handling was allowing the recursive /boards
appending. That doesn't have to be fixed for this ticket, but if it's not we should create another ticket to track fixing that.
Just did some testing and it appears resolved. My concern is still that our error handling was allowing the recursive
/boards
appending. That doesn't have to be fixed for this ticket, but if it's not we should create another ticket to track fixing that.
Thanks @Pinjasaur, can you create a new ticket for that issue? Closing this one out.
@sbishel is also fixing something around this.
@sbishel need a ticket or issue created?
@Pinjasaur My fix https://github.com/mattermost/focalboard/pull/3880, also fixed the issue before the error loop. So we probably need a ticket to investigate the error looping, but need a way to duplicate since these now won't occur.
#3937