focalboard icon indicating copy to clipboard operation
focalboard copied to clipboard

Published 20 hours ago • verified publisher icon mattermost

Bug: infinite error redirect loop

Open Pinjasaur opened this issue 1 year ago • 3 comments

Steps to reproduce the behavior

  1. Go to a board with a view that causes an error Boards: Sprints in https://boards-bugbash73.test.mattermost.cloud/boards/team/emkcjitr1jfs5nzhntbj6dzztr/bcic7hnpf1bnf8x9b6hnxqhqmpc/v51b4fn1f7brfxkfk49cwzzndnr
  2. Attempt to select the same error view again
  3. Observe error redirect loop (1+ minute)

Expected behavior

Not stuck in error redirect loop.

Screenshots (optional)

https://user-images.githubusercontent.com/6335792/189202768-6db8d989-cb59-4a87-a141-59698e4dd547.mov

Edition and Platform

  • Edition: Mattermost Boards (plugin)
  • Version: bugbash 7.3
  • Browser and OS: FF105 Mac

Additional context (optional)

Add any other context about the problem here, and any notes about the severity:

  • Sev 1: Affects critical functionality without a workaround
  • Sev 2: Affects major functionality with a difficult or non-obvious workaround
  • Sev 3: Affects minor, non-critical functionality

Pinjasaur avatar Sep 08 '22 18:09 Pinjasaur

May be happening on community as well: https://community.mattermost.com/private-core/pl/humyg56q87g7brrx9uboqtj8dh

wiggin77 avatar Sep 08 '22 19:09 wiggin77

@wuwinson @Pinjasaur this was fixed by #3793 I've uploaded lagtest 7.3 with the patch on bugbashs server. Please give it a go.

harshilsharma63 avatar Sep 12 '22 11:09 harshilsharma63

Just did some testing and it appears resolved. My concern is still that our error handling was allowing the recursive /boards appending. That doesn't have to be fixed for this ticket, but if it's not we should create another ticket to track fixing that.

Pinjasaur avatar Sep 12 '22 20:09 Pinjasaur

Just did some testing and it appears resolved. My concern is still that our error handling was allowing the recursive /boards appending. That doesn't have to be fixed for this ticket, but if it's not we should create another ticket to track fixing that.

Thanks @Pinjasaur, can you create a new ticket for that issue? Closing this one out.

wuwinson avatar Oct 03 '22 19:10 wuwinson

@sbishel is also fixing something around this.

harshilsharma63 avatar Oct 04 '22 10:10 harshilsharma63

@sbishel need a ticket or issue created?

Pinjasaur avatar Oct 05 '22 20:10 Pinjasaur

@Pinjasaur My fix https://github.com/mattermost/focalboard/pull/3880, also fixed the issue before the error loop. So we probably need a ticket to investigate the error looping, but need a way to duplicate since these now won't occur.

sbishel avatar Oct 05 '22 20:10 sbishel

#3937

Pinjasaur avatar Oct 05 '22 21:10 Pinjasaur