focalboard icon indicating copy to clipboard operation
focalboard copied to clipboard

Remove synthetic/implicit memberships for guests

Open Pinjasaur opened this issue 1 year ago • 4 comments

Summary

See #3771 for details, but the concept of having a synthetic membership for a guest is removed. They will need to be explicitly added to a board via the Share modal.

See #3785 for tracking of the modal dialog copy to reflect this change. cc @wuwinson

Ticket Link

closes #3771

Pinjasaur avatar Sep 06 '22 21:09 Pinjasaur

/update-branch

Pinjasaur avatar Sep 13 '22 18:09 Pinjasaur

/update-branch

Pinjasaur avatar Sep 13 '22 21:09 Pinjasaur

Would like someone's input on the addition to the query to make sure that looks good. Additionally the /boards/search API will need to be updated to only include boards that guests are explicit members of. See #3771.

Pinjasaur avatar Sep 13 '22 23:09 Pinjasaur

/update-branch

sbishel avatar Sep 14 '22 13:09 sbishel

/update-branch

Pinjasaur avatar Sep 29 '22 18:09 Pinjasaur

@Pinjasaur - Can this be merged?

sbishel avatar Sep 30 '22 15:09 sbishel

@Pinjasaur - Can this be merged?

@sbishel nearly, just need to update the /boards/search endpoint as mentioned above. That was my intention today along with a PR for #3785 to update the modal copy based on these changes.

Pinjasaur avatar Oct 03 '22 14:10 Pinjasaur

/update-branch

Pinjasaur avatar Oct 03 '22 21:10 Pinjasaur

@sbishel should be good to go, if you could give the changes to /boards/search endpoint a once-over: fe0121b (#3786)

Pinjasaur avatar Oct 03 '22 21:10 Pinjasaur

Cherry pick is scheduled.

mattermod avatar Oct 04 '22 00:10 mattermod