Bug: Template picker displays custom templates that are not editable nor removable

[wuwinson]

Steps to reproduce the behavior

1. Go to https://community-dr.staging.cloud.mattermost.com/boards/
2. Open the template picker
3. Scroll down to past the standard templates and hover over the migrated custom templates
4. See error - some custom templates do not have the option to edit nor delete
5. For other migrated custom templates where I can edit - when opening the share modal to those templates in edit mode, I can see synthetic channel memberships even though that was not covered in the original spec on template migrations

Expected behavior

As of v7.2, we only support Editor and Admin roles. Any custom templates that are shared with me and visible on the template picker should be at a minimum editable by me, since the I'd have to be an Editor of the template to even see it on the template picker. If I'm an admin on the custom template, then I should also have the option of deleting the template.

If the template is not shared with me, then it should not appear on the template picker. The only templates that should not be editable are the standard templates (as of v7.2).

Screenshots (optional)

https://user-images.githubusercontent.com/93531870/182745971-5b8fc448-13bd-4974-8047-bdb1fbb2a4cc.mov

Edition and Platform

• Edition: Mattermost Boards (plugin)
• Version: v7.2
• Browser and OS: Chrome on Mac

[wuwinson]

Maybe related to #3531

cc @sbishel @chenilim

[jespino]

After investigating it, it can be possible, you are seeing all the "public" templates, that are the ones that "allows you to join by default", but for templates the meaning is different, is "anyone can use it, but not necessarily join". So... you don't have edit or delete permissions until you get explicitly invited or you find the way to join it (the interface doesn't allow you to do that).

You are seeing there the builtin templates, the templates that you are member of, and the public templates that third category looks like the ones that you can't manage. Do you think that is wrong @wuwinson ?

[wuwinson]

@jespino I did a little investigating as well, and confirmed that they are most likely due to setting the team role on the templates as "Editor". Personally I think this is preferable to not allow team members to edit the template unless they are explicitly added by the admin, but the role "Editor" is misleading then. We should rename the role dropdown specifically for the template editor to something more accurate. Either renaming it "Viewer" or something along the lines of "Access / no access". @justinegeffen @asaadmahmood Thoughts on this?

Additionally, I also tried linking a channel to the template, and nothing happens. Regardless if the 2nd user was a member of that channel or not. We should either hide channels in the template share modal or fix it so that only members of those channels can see the template. Whichever is easier for v7.2. @sbishel @chenilim Thoughts?

See recording using 2 users:

https://user-images.githubusercontent.com/93531870/182990861-fcce71a8-70c8-420d-8b7b-7138a33598f6.mov

[wuwinson]

@jespino Updated this ticket and separated https://github.com/mattermost/focalboard/issues/3625 into its own ticket.

[jespino]

@asaadmahmood do you mind to make a specific UX proposal for this change? I don't need a full UX, It would be just enough with a textual description with the exact texts used.

[asaadmahmood]

@jespino I am more inclined to change it as "Viewer". I can also think of separate ways to differentiate the share template modal from the share board modal, which we can do later.