focalboard icon indicating copy to clipboard operation
focalboard copied to clipboard

[GH-1732] Add person filter

Open hyugabokko opened this issue 1 year ago • 6 comments

Summary

PR #1963 has a improvement that resolves #1732, but appears to have been left as a work in progress. This PR takes a portion of the code modified in #1963 and makes additional code modifications.

Changes

Specifically, the following code changes were made

  • Based on PR #1963, I edited the filterComponent.tsx and the filterEntry.tsx so that a property of type "person" appears as a filter item.
  • When attempting to display the value of a filter, the userlist of the board will be displayed in the case of a property of type "person".
    • For other property types, the value is added to the options at the stage of adding the property to the card. However, for a property of type "person", options must be changed each time a user is added or removed from the board. Therefore, I have determined that it is appropriate to retrieve the userlist when displaying the filter and treat it as a options. This implementation is controversial so it should be specifically checked during the review process.
  • To get the userlist for a board in the filterEntry.tsx, I have added the userlist to state in a unit test (filterEntry.test.tsx).

The following gifs are shown as proof of operation.

Behavior

Animation

Ticket Link

Fixes #1732

hyugabokko avatar Aug 01 '22 15:08 hyugabokko

Hello @hyugabokko,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Aug 01 '22 15:08 mattermod

/update-branch

wiggin77 avatar Aug 09 '22 19:08 wiggin77

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Aug 20 '22 01:08 mattermod

@jespino - With your properties refactor, can this PR be closed or is there still value in the PR

sbishel avatar Aug 31 '22 20:08 sbishel

How can we move this PR forward? Very critical feature

Tonfa avatar Oct 05 '22 20:10 Tonfa

Any progress on this? Any TODOs that are holding it up? I might be able to contribute. My team would really love this feature. Or in general, to be able to filter by Assignee somehow.

Dakine135 avatar Oct 24 '22 17:10 Dakine135

@jespino Following-up on this. Is there any additional work needed on this PR after your refactor? This is one of the top requested features by our users and it would be amazing if we could get this in. Thanks!

wuwinson avatar Nov 10 '22 19:11 wuwinson

Closing as no longer relevent.

sbishel avatar Feb 13 '23 21:02 sbishel

In case anyone is wondering if this feature now exists: The changelog says: "Added support for person, multi-person and date property filters in boards." as of Mattermost 7.8 "See the docs for more details.

vonunwerth avatar Mar 29 '23 05:03 vonunwerth