focalboard icon indicating copy to clipboard operation
focalboard copied to clipboard

Published 20 hours ago • verified publisher icon mattermost

[MM-43781] Feature: boards insights

Open plant99 opened this issue 2 years ago • 12 comments

Summary

This PR introduces 2 endpoints to get boards insights.

/users/<user-id>/boards/insights?duration<time> /teams/<team-id>/boards/insights?duration=<time>

time can be of the format

  • 1 day
  • 3 minute
  • 2 year

Ticket Link

JIRA: https://mattermost.atlassian.net/browse/MM-43781

plant99 avatar May 02 '22 13:05 plant99

Hello @plant99,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar May 02 '22 13:05 mattermod

@plant99 can you share any requirement doc for this? That'll help in the review.

harshilsharma63 avatar May 03 '22 12:05 harshilsharma63

Added 2 comments for now as I haven't gone through the entire PR yet. Will review this again.

harshilsharma63 avatar May 03 '22 12:05 harshilsharma63

@harshilsharma63 https://github.com/mkraft/suite-users/blob/main/tech-specs/activity-and-insights-widgets/top-boards.md this is a brief design doc.

I'm still working on two things.

  • https://github.com/mattermost/focalboard/pull/3005/files#diff-b9c5dee0af94791cf10c365cac0a7b054a4cc0d3e10b329fe9a4942d42f590c0 there are more cases to be added here, and they'd be made stricter with more assert statements.
  • https://github.com/mattermost/focalboard/pull/3005/files#diff-4c7fcc4f7fcc084199c81be767b488432860acc05e6d5d29bdb1dadf66064b52R127 tests for the new utility functions in sqlstore_test.go

plant99 avatar May 04 '22 13:05 plant99

While I'll come back to this PR, @mkraft and @jespino please look at the one against release-7.0 . I've tried to fix things there based on the feedback I got here.

plant99 avatar May 25 '22 06:05 plant99

Thanks for the review @mkraft , the queries are written with squirrel fully now. Addressed other concerns as well.

plant99 avatar Jul 20 '22 08:07 plant99

Let me know if/when this is ready for review.

@wiggin77 it is now ready for review.

plant99 avatar Jul 20 '22 08:07 plant99

/update-branch

wiggin77 avatar Jul 28 '22 21:07 wiggin77

/update-branch

sbishel avatar Aug 02 '22 23:08 sbishel

@BenCookie95 could you please update the plugin frontend if necessary? similar to this commit

Let's merge that commit into this PR.

plant99 avatar Aug 03 '22 05:08 plant99

@plant99 sorry for the delay. I'll be reviewing this today.

harshilsharma63 avatar Aug 05 '22 08:08 harshilsharma63

/update-branch

wiggin77 avatar Aug 05 '22 15:08 wiggin77

I understand that we had to rush this because of 7.2 deadline, but if there are any other improvements you'd like to see in the merged code, please feel free to create tickets and assign it to me. Thanks for all your reviews.

plant99 avatar Aug 08 '22 06:08 plant99