docs icon indicating copy to clipboard operation
docs copied to clipboard

Correct a unit conversion for the FileSettings.MaxFileSize config setting, make clear that IEC units are used

Open zsrv opened this issue 10 months ago • 7 comments

Summary

This PR corrects a unit conversion for the FileSettings.MaxFileSize configuration setting (104857600 bytes is 100 mebibytes), and uses IEC prefix names instead of SI prefix names to make clear how values entered in the System Console will be interpreted.

A code comment here indicates that IEC units should be used.

Ticket Link

None

zsrv avatar Apr 23 '24 17:04 zsrv

Hello @zsrv,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermost-build avatar Apr 23 '24 17:04 mattermost-build

Newest code from cwarnermm has been published to preview environment for Git SHA 2d01b7171b12ba9a972ff8d7bb4e46cf12d607d3

github-actions[bot] avatar Apr 23 '24 18:04 github-actions[bot]

Newest code from mattermost-build has been published to preview environment for Git SHA 2d01b7171b12ba9a972ff8d7bb4e46cf12d607d3

github-actions[bot] avatar Apr 23 '24 18:04 github-actions[bot]

@zsrv are you open to fixing the remaining instances of SI units as well?

harshilsharma63 avatar Apr 26 '24 05:04 harshilsharma63

@harshilsharma63 sure, I'll work on it this weekend.

zsrv avatar Apr 26 '24 09:04 zsrv

@harshilsharma63 I've added an additional commit that makes the clarification for the MS Teams plugin, but there are two parts that I think I'll need someone with access to the Mattermost Enterprise code to verify:

https://github.com/mattermost/docs/blob/8c24d2e2e0c5ee6f192dd1b5e2f5335849466a54/source/configure/experimental-configuration-settings.rst?plain=1#L855 https://github.com/mattermost/docs/blob/8c24d2e2e0c5ee6f192dd1b5e2f5335849466a54/source/manage/logging.rst?plain=1#L395

I couldn't find usages of these config options in the open source code base, so as these are related to enterprise-only features I assume they are only used in the enterprise code base.

zsrv avatar Apr 30 '24 11:04 zsrv

Newest code from cwarnermm has been published to preview environment for Git SHA 3f15eaba9ae37330b4f138ba6a2ba8ff1ccc0c31

github-actions[bot] avatar May 02 '24 20:05 github-actions[bot]