docs icon indicating copy to clipboard operation
docs copied to clipboard

Help Wanted: Open all external links in a new browser tab

Open cwarnermm opened this issue 2 years ago • 15 comments

Problem space Currently, links to external sites from the Mattermost product documentation take the visitor away from docs.mattermost.com.

Target audience All users

Goal All external links across the product documentation site open in a new browser tab, rather than the current tab.

Delivery expectations

  • 1 PR with all proposed changes
  • Leave all links to other pages of the product documentation site as-is.
  • Links to the Mattermost Developer or API documentation sites count as an external site link and should be updated.
  • Comment in the PR to request a generated preview of your work. The Docs team will add the appropriate labels to your PR.

Tech needed

  • HTML,
  • RST, MD formats
  • Sphinx

Affected repository mattermost/docs

Where to get help Join the Mattermost Docs team on the Mattermost Community Server in the ~Documentation Working Group channel to discuss this ticket, or feel free to comment in this docs ticket.

cwarnermm avatar Oct 05 '22 17:10 cwarnermm

I can help in solving this issue can you assign me this issue?

Abhishek-Vaidya avatar Oct 05 '22 18:10 Abhishek-Vaidya

Happy to have your help with this documentation improvement, @Abhishek-Vaidya!

cwarnermm avatar Oct 05 '22 18:10 cwarnermm

can I know the path of the HTML and JavaScript files of the documentation webpages, so that I can edit them and solve your issue? I was unable to find these files.

Abhishek-Vaidya avatar Oct 05 '22 18:10 Abhishek-Vaidya

HTML templates can be found in source/templates, and CSS/JS files can be found in source/_static.

neflyte avatar Oct 06 '22 17:10 neflyte

Hi @Abhishek-Vaidya! One approach to a ticket like this might be to format all links site-wide to open in a new tab. However, this particular documentation site features a mix of links that point to other pages of the same doc set as well as external links to other websites. With this in mind, formatting all links to open a certain way may impact more links than intended.

Another approach to this ticket may include encoding only the external links on a given docs page to open in a new tab. This would ensure that only the links that include such configuration would open that way, and all other links would open within the same tab.

cwarnermm avatar Oct 06 '22 17:10 cwarnermm

@Abhishek-Vaidya - Are you actively working on this ticket?

cwarnermm avatar Nov 01 '22 18:11 cwarnermm

This ticket is up for grabs.

cwarnermm avatar Jan 18 '23 14:01 cwarnermm

I'm ready to grab this issue. Please assign this to me.

devharipragaz007 avatar Apr 10 '24 17:04 devharipragaz007

Thank you, @devharipragaz007!

cwarnermm avatar Apr 10 '24 17:04 cwarnermm

Hi @cwarnermm and @devharipragaz007, may I also contribute to this ticket if it is still open?

chessmadridista avatar Jun 08 '24 04:06 chessmadridista

Thanks, @chessmadridista. Looking forward to your docs PR addressing this issue.

cwarnermm avatar Jun 10 '24 13:06 cwarnermm

Is this issue the same as #7059?

chessmadridista avatar Jun 11 '24 10:06 chessmadridista

@chessmadridista - Yes, it's the same issue with potentially the same root cause (pending further investigation).

cwarnermm avatar Jun 11 '24 12:06 cwarnermm

Hi @cwarnermm, I have created a PR for this issue.

Usually, how much time does it take to merge a PR?

chessmadridista avatar Jun 12 '24 11:06 chessmadridista

Thanks, @chessmadridista! Next steps for your PR is a technical and editorial review. The docs team aims to review & merge docs PRs within a business week, though timelines can vary.

cwarnermm avatar Jun 12 '24 12:06 cwarnermm