desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Rename variables from "team" to "server" in source code

Open yuya-oc opened this issue 7 years ago • 6 comments

I confirm (by marking "x" in the [ ] below):


Jira: https://mattermost.atlassian.net/browse/MM-14093

Summary Rename variables from "team" to "server" in source code. The name has been originally since there is no team side bar in webapp. In that time, the app need to handle "team" URL (https://SERVER/TEAM) to show multiple teams in the single window. Now it's confusing so we need to rename for readability.

NOTE: There is a distinction between server and team, some of the code is actually talking about server when using team, however, the MM webapp actually has the concept of a team, so some uses of team in the code should stay as team. Please reach out if this is difficult to determine!

Possible fixes

  • Rename variables by searching.
  • Consider upgrading config.json schema version.

yuya-oc avatar Oct 14 '17 12:10 yuya-oc

would like to do this as my first contribution and getting to know the project :)

thepill avatar Jan 03 '19 17:01 thepill

Jira ticket for tracking: https://mattermost.atlassian.net/browse/MM-14093.

amyblais avatar Feb 11 '19 16:02 amyblais

Updated the summary with an important note about server vs. team.

deanwhillier avatar May 04 '20 13:05 deanwhillier

Copy the entire code on a text editor and then search for keywords, and change accordingly, or send me the code I shall do it for you.

alphaninja27 avatar Oct 01 '21 17:10 alphaninja27

I would like to solve the issue

NickyHarry123 avatar Jan 25 '22 04:01 NickyHarry123

@harika551 Are you still planning on working on this?

devinbinnie avatar Aug 09 '22 13:08 devinbinnie