desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Fix bad path name for user data dir, upgrade node-abi

Open devinbinnie opened this issue 8 months ago • 9 comments

Summary

Found an issue causing the Windows E2E tests to not run, this PR should fix it.

NONE

devinbinnie avatar Apr 24 '25 17:04 devinbinnie

@yasserfaraazkhan Can you help re-enable Windows tests for this PR?

devinbinnie avatar Apr 24 '25 17:04 devinbinnie

:tada: Snyk checks have passed. No issues have been found so far.

:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)

:white_check_mark: license/snyk check is complete. No issues have been found. (View Details)

mm-prodsec-bot avatar Apr 24 '25 23:04 mm-prodsec-bot

Hi @toninis @saturninoabril https://github.com/mattermost/desktop/actions/runs/14749804652/job/41404418955?pr=3406#step:10:272

We been facing this gpu error in linux runners. Tried few things, but nothing fixed it. any chance you might have seen this error somewhere?

If there's no solution, I'll disable the linux tests

yasserfaraazkhan avatar Apr 30 '25 08:04 yasserfaraazkhan

We been facing this gpu error in linux runners. Tried few things, but nothing fixed it. any chance you might have seen this error somewhere?

If there's no solution, I'll disable the linux tests

Hello @yasserfaraazkhan, I wonder if we should switch to using the provided docker image when running in Linux, like:

image: mcr.microsoft.com/playwright:v1.52.0-noble

saturninoabril avatar May 06 '25 15:05 saturninoabril

/update-branch

yasserfaraazkhan avatar May 08 '25 10:05 yasserfaraazkhan

/update-branch

yasserfaraazkhan avatar May 21 '25 02:05 yasserfaraazkhan

/update-branch

devinbinnie avatar May 23 '25 14:05 devinbinnie

Error trying to update the PR. Please do it manually.

mattermost-build avatar May 23 '25 14:05 mattermost-build

@devinbinnie this should be good to merge.

I'll follow up with the fix if anything fails.

yasserfaraazkhan avatar May 26 '25 15:05 yasserfaraazkhan

/update-branch

devinbinnie avatar Jun 19 '25 14:06 devinbinnie