desktop
desktop copied to clipboard
mattermost
feat: propagate the window title from browser view to main window
Summary
Propagate the window title provided by the browser view, which would normally set the window/tab's title, to the MainWindow, so that the application's title reflects the currently selected server, workspace and channel.
The use case for me is that I work on many different projects and have automated my time-tracking using ManicTime. With this tool I can auto-tag time spent in applications, windows and thus correlate this time with projects. The window title is one of the properties that can be used to disambiguate between the various tasks being carried out.
Checklist
- [x] Added or updated unit tests (required for all new features)
- [x] Has UI changes
- [x] read and understood our Contributing Guidelines
- [x] completed Mattermost Contributor Agreement
- [x] executed
npm run lint:jsfor proper code formatting
Device Information
Windows 10
Release Note
The application windows's title now reflects the current channel/user, workspace and server name.
Hello @hennejg,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
Please note that I am currently on holidays. I'll look into your comments some time next week.
@devinbinnie sorry, that topic landed on the back-burner. I'll try to finde some time ASAP.
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
Sorry for the delay. I had a look at this. Although I did not make any more changes, I think the PR is ready for review as-is. Issues raised earlier have been addressed. If there is anything else that needs to be done, I'd need some hints.