desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Published 20 hours ago • verified publisher icon mattermost

Update Display Name for MSI

Open JtheBAB opened this issue 2 years ago • 4 comments

Summary

Update Display Name to Mattermost Desktop to reflect the real name. Sorry don't know where to change the exe builder :/

NONE

JtheBAB avatar May 17 '22 14:05 JtheBAB

Hello @JtheBAB,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar May 17 '22 14:05 mattermod

Thanks @JtheBAB, I'm not sure this one is necessary though. I think the app name (at least on Windows) is still Mattermost.

devinbinnie avatar May 17 '22 16:05 devinbinnie

I find it just strange as everywhere it is Mattermost Desktop. But there not. But up to you guys :)

JtheBAB avatar May 17 '22 19:05 JtheBAB

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar May 28 '22 01:05 mattermod

@devinbinnie Feel free to give approval so that I can merge :)

wget avatar Jan 19 '23 11:01 wget

@wget Before I approve, and forgive my ignorance because I'm not super familiar with MSI building myself other than what I've had to work with, but is there any risk in changing the name here? Does that change the name of any shortcuts? Would notifications be affected (since Windows bases their existence off of some ID)?

devinbinnie avatar Jan 19 '23 14:01 devinbinnie

@devinbinnie I don't pretend to know everything about msi myself either, but what matters most (:yum: ) is the Product Id and UpgradeCode attribute, not the name :) In the past, that name was usually changed depending on the version used to make it look different in the Add/Remove program control panel element. So yes, the Name doesn't matter here. That name was important for Chocolatey for example when we hadn't any msi installer yet, chcolatey relied on it to grab the Uninstall string from the registry. Now with msi installer, they use the ID.

I checked by myself and an upgrade process is working flawlessly between a 5.2.2 and a 5.3.0-develop (with the new name).

Before: Screenshot_20230120_204333 After: Screenshot_20230120_212156

In the installer GUI (the name is also changed everywhere else, but I'm not gonna do screenshots for all of them :P ): Screenshot_20230120_212126

wget avatar Jan 20 '23 20:01 wget

Seems like this is something everyone wants, so I shall approve and merge. Thanks @JtheBAB and @wget :)

devinbinnie avatar Jan 22 '23 07:01 devinbinnie