[MM-43656] Flush cookies to disk on finishing custom login

[devinbinnie]

Summary

OneLogin's 'Remember me' feature wasn't working, and I think the issue was that we weren't saving cookies to disk until after the user blurs the app (or closes it).

Ticket Link

https://mattermost.atlassian.net/browse/MM-43656

Fixed an issue where OneLogin users wouldn't have their credentials remembered.

[mattermod]

Building app in separate branch.

[mattermod]

Successfully building:
https://circleci.com/gh/mattermost/desktop/19512
https://circleci.com/gh/mattermost/desktop/19511
https://circleci.com/gh/mattermost/desktop/19510

[mattermod]

Artifact links:
https://output.circle-artifacts.com/output/job/3dc3c354-e663-47ca-bb12-43c5df0bb1c5/artifacts/0/tmp/artifacts/mattermost-desktop-5.1.0-develop.1-mac-arm64.dmg
https://output.circle-artifacts.com/output/job/3dc3c354-e663-47ca-bb12-43c5df0bb1c5/artifacts/0/tmp/artifacts/mattermost-desktop-5.1.0-develop.1-mac-x64.dmg
https://output.circle-artifacts.com/output/job/2de424a3-ed3b-4269-9122-90a1d8213bb8/artifacts/0/tmp/artifacts/mattermost-desktop-setup-5.1.0-develop.1-win.exe
https://output.circle-artifacts.com/output/job/0b48ec72-afe2-4ea4-8c10-4d38f629e07e/artifacts/0/tmp/artifacts/mattermost-desktop-5.1.0-develop.1-linux-ia32.tar.gz
https://output.circle-artifacts.com/output/job/0b48ec72-afe2-4ea4-8c10-4d38f629e07e/artifacts/0/tmp/artifacts/mattermost-desktop-5.1.0-develop.1-linux-x64.tar.gz

[amyblais]

@devinbinnie Is this planned for v5.1, or do we remove the milestone from the ticket/PR?

[devinbinnie]

@amyblais It can wait until the next release, it's not super urgent.

[devinbinnie]

/update-branch

[mattermost-build]

Building app in separate branch.

[mattermost-build]

Successfully building:
https://circleci.com/gh/mattermost/desktop/27897
https://circleci.com/gh/mattermost/desktop/27896
https://circleci.com/gh/mattermost/desktop/27895

[mattermost-build]

Artifact links:
https://output.circle-artifacts.com/output/job/ed120963-fcad-4fc3-bbcd-5eccc026d420/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-mac-m1.dmg
https://output.circle-artifacts.com/output/job/ed120963-fcad-4fc3-bbcd-5eccc026d420/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-mac-x64.dmg
https://output.circle-artifacts.com/output/job/e69b8de5-4ec9-47e2-a2ca-8060ba9dcf36/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-win-arm64.zip
https://output.circle-artifacts.com/output/job/e69b8de5-4ec9-47e2-a2ca-8060ba9dcf36/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-win-ia32.zip
https://output.circle-artifacts.com/output/job/e69b8de5-4ec9-47e2-a2ca-8060ba9dcf36/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-win-x64.zip
https://output.circle-artifacts.com/output/job/5fa0ecaa-1319-4a88-bfc7-34c9ec25aa5a/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-linux-arm64.tar.gz
https://output.circle-artifacts.com/output/job/5fa0ecaa-1319-4a88-bfc7-34c9ec25aa5a/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-linux-x64.tar.gz

[jgilliam17]

Thanks @devinbinnie Tested on macOS - works great, I didn't know I needed this 🙂 On Win 10 - At login, app opens on Playbooks each time. Not on Playbooks tab, Channels tab in focus with Playbooks product shown on product switcher. Haven't checked Ubunto yet, that's next - will comment shortly

[devinbinnie]

Thanks @devinbinnie Tested on macOS - works great, I didn't know I needed this 🙂 On Win 10 - At login, app opens on Playbooks each time. Not on Playbooks tab, Channels tab in focus with Playbooks product shown on product switcher. Haven't checked Ubunto yet, that's next - will comment shortly

Looks like a separate issue. If you are able to reproduce can you file a ticket for us and we'll have a look? :) As long as the usernames are being remembered correctly we should be okay to approve this :)

[jgilliam17]

Thanks @devinbinnie - LGTM I'll file Playbook on login issue separately