desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Substitute tgz target for one that keeps permissions

Open mattermod opened this issue 4 years ago • 4 comments

On <MM-21400> we added a setuid permission, this is not being kept by electron-builders target as it is using 7za on linux and does not preserve file permissions.

To overcome this, we need to remove the tgz target from our list and do it within another of the linux targets, reimplementing the feature

In order to get that, the easiest way is to interact with the beforepack scripts and create a different tgz there, or if there are any additional steps during the pack, we can do the same on the after pack, making sure permissions (setuid bit) are kept

HW shell script/easy


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-22377

mattermod avatar Apr 21 '20 16:04 mattermod

Thanks William :)

esethna avatar Apr 21 '20 17:04 esethna

@wget Don't suppose you're still looking at this are you?

devinbinnie avatar Dec 09 '21 20:12 devinbinnie

@devinbinnie Thanks for the nudge. Last time I checked, it was indeed cumbersome to modify the way electron-builder was behaving. Let's seeif the situation changed one year later... or if this suid permission is still needed. Have scheduled this for the week-end.

I have commented for the other pending PR 1405 as well.

wget avatar Dec 10 '21 15:12 wget

@wget Awesome, let me know what you come up with :)

devinbinnie avatar Dec 10 '21 15:12 devinbinnie

This was resolved in a different PR. Closing.

devinbinnie avatar Aug 09 '22 13:08 devinbinnie