desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Link opened by clicking notification is truncated

Open tanmayrajani opened this issue 4 years ago • 5 comments

I confirm:


Summary Link opened by clicking notification is truncated. It opens only the part of the link which is visible in the notification

Environment

  • Operating System: Ubuntu 16.04.6 LTS 64-bit
  • Mattermost Desktop App version: 4.2.3
  • Mattermost Server version: 5.13.2

Steps to reproduce

  1. Send a link as part of the message (somewhat longer link so that half the link is visible)
  2. Click on the link in the notification

Expected behavior

  • Whole link should be opened in browser

Observed behavior

  • Only the visible part of the link opened in browser

Example

  • Actual Message: Please create an issue for that here: https://github.com/mattermost/desktop/issues
  • Visible Message in notification: Please create an issue for that here: https://github.com/mattermost/desk (here it opens https://github.com/mattermost/desk in the browser when clicked)

tanmayrajani avatar Oct 15 '19 08:10 tanmayrajani

If someone can point me on where to start looking, I'd like to try and help fix this

tanmayrajani avatar Oct 16 '19 09:10 tanmayrajani

This bug is still present

archiekennedy avatar Mar 12 '21 16:03 archiekennedy

Created a JIRA ticket: https://mattermost.atlassian.net/browse/MM-40568

devinbinnie avatar Dec 09 '21 20:12 devinbinnie

Same thing on the Webapp, both Firefox and Chromium. Not sure where to report that.

dreua avatar Jan 20 '22 15:01 dreua

I found the relevant code in mattermost-webapp/actions/notification_actions.jsx#L136-L139:

        let strippedMarkdownNotifyText = stripMarkdown(notifyText);
        if (strippedMarkdownNotifyText.length > NOTIFY_TEXT_MAX_LENGTH) {
            strippedMarkdownNotifyText = strippedMarkdownNotifyText.substring(0, NOTIFY_TEXT_MAX_LENGTH - 1) + '...';
        }

Unfortunately the "desktop" development environment does not help here, I'll need to check the webapp next...

dreua avatar Jan 20 '22 15:01 dreua