zksync-web-era-docs icon indicating copy to clipboard operation
zksync-web-era-docs copied to clipboard

Idiomatic updates to compiler docs PR

Open FlashSheridan opened this issue 1 year ago • 1 comments

Testing the patches to PR new suggestion mechanism, first with Idiomatic updates to compiler overview.md. (It may be easier to accumulate edits in this PR before merging my branch into yours.)

FlashSheridan avatar Mar 24 '23 17:03 FlashSheridan

Ah, these commits are not suggestions :)

hedgar2017 avatar Mar 26 '23 01:03 hedgar2017

@FlashSheridan @hedgar2017 I'll deal with this when we have the main PR merged because there are changes to my changes in this PR and I will have to go through everything again in detail.

kailash-manasarovar avatar Mar 28 '23 09:03 kailash-manasarovar

Visit the preview URL for this PR (updated for commit 7346664):

https://aqwzx-zksync-v2-docs--pr357-flash-patches-to-az-zljv5y4i.web.app

(expires Mon, 10 Apr 2023 12:52:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ec4de9998e9e17237caea0ab05986cdbc32c4efb

github-actions[bot] avatar Mar 28 '23 09:03 github-actions[bot]

@kailash-manasarovar yes, please wait until we sort it out among ourselves. We'll rebase it into main then.

hedgar2017 avatar Mar 28 '23 20:03 hedgar2017

@kailash-manasarovar yes, please wait until we sort it out among ourselves. We'll rebase it into main then.

I'm going to have to do it manually by the looks as it is sentence by sentence (word by word) merge conflicts and the language needs a review too.

kailash-manasarovar avatar Mar 29 '23 06:03 kailash-manasarovar

:tada: This PR is included in version 1.3.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Apr 11 '23 11:04 github-actions[bot]