zksync-era icon indicating copy to clipboard operation
zksync-era copied to clipboard

feat(contracts)!: synclayer integration

Open StanislavBreadless opened this issue 9 months ago • 2 comments

What ❔

This is a semi-stable branch for sync layer integration. It is still WIP and big changes are expected

Why ❔

Checklist

  • [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • [ ] Tests for the changes have been added / updated.
  • [ ] Documentation comments have been added / updated.
  • [ ] Code has been formatted via zk fmt and zk lint.
  • [ ] Spellcheck has been run via zk spellcheck.

StanislavBreadless avatar May 14 '24 17:05 StanislavBreadless

Detected VM performance changes

Benchmark name change in estimated runtime change in number of opcodes executed
deploy_simple_contract N/A -105 (-0.6%)
event_spam N/A +65 (+0.0%)
write_and_decode N/A +183 (+0.0%)
finish_eventful_frames N/A -42 (-0.0%)
call_far N/A -72 (-0.0%)
decode_shl_sub N/A +194 (+0.0%)
slot_hash_collision N/A +183 (+0.0%)
access_memory N/A +183 (+0.0%)

Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it run out of gas at a different time. Or that it is behaving completely differently.

github-actions[bot] avatar Jun 18 '24 17:06 github-actions[bot]

Folks, this PR is getting scary each passing day. What's the plan to integrate it?

EmilLuta avatar Jul 31 '24 10:07 EmilLuta