zksync-era icon indicating copy to clipboard operation
zksync-era copied to clipboard

feat: enhance unit test for batch tip

Open Artemka374 opened this issue 11 months ago • 1 comments

What ❔

Add a few more hardcoded constants for batch tip unit test.

Why ❔

To measure correct values for further removing of the batch_dry_run

Checklist

  • [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • [ ] Tests for the changes have been added / updated.
  • [ ] Documentation comments have been added / updated.
  • [ ] Code has been formatted via zk fmt and zk lint.
  • [ ] Spellcheck has been run via zk spellcheck.
  • [ ] Linkcheck has been run via zk linkcheck.

Artemka374 avatar Feb 26 '24 17:02 Artemka374

gas_used metric is the same as max_used_gas, so didn’t add this constant. All the values are multiplied by 2 to have an overhead(in case not all edge cases are checked). Also wasn’t added constant for block writes - not sure that we can do this in this test.

Artemka374 avatar Feb 26 '24 18:02 Artemka374