zksync-era icon indicating copy to clipboard operation
zksync-era copied to clipboard

feat: Use unwrap for contract address for transaction receipt

Open Artemka374 opened this issue 11 months ago • 4 comments

What ❔

Use unwrap() on transactions.data -> contractAddress field in transactions table.

Why ❔

Seems there are no NULL values for this field, PR is intended to ensure this(to be able to return NULL values later).

Checklist

  • [x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • [x] Tests for the changes have been added / updated.
  • [x] Documentation comments have been added / updated.
  • [x] Code has been formatted via zk fmt and zk lint.
  • [x] Spellcheck has been run via zk spellcheck.
  • [x] Linkcheck has been run via zk linkcheck.

Artemka374 avatar Feb 26 '24 12:02 Artemka374

@Artemka374 can you please elaborate a little more in the PR description? What field exactly do you mean and why are you addressing this now

RomanBrodetski avatar Feb 26 '24 16:02 RomanBrodetski

@RomanBrodetski updated, was hoping it will be merged quickly, so didn’t think a lot on the description :)

Artemka374 avatar Feb 26 '24 17:02 Artemka374

Seems there are no NULL values for this field, PR is intended to ensure this(to be able to return NULL values later).

Still don't understand, sorry.. Don't want to block this - LMK if it's urgent and I'll aprove, but generally we want PR descriptions to make sense because we use them as our changelog

RomanBrodetski avatar Feb 26 '24 18:02 RomanBrodetski

It’s more dependent on @StanislavBreadless as he is one that wanted this to be done

Artemka374 avatar Feb 26 '24 19:02 Artemka374