zksync-cli icon indicating copy to clipboard operation
zksync-cli copied to clipboard

fix: wrap pathes for docker compose in quotes

Open 0xVolosnikov opened this issue 9 months ago • 2 comments

What :computer:

Fix for https://github.com/matter-labs/zksync-cli/issues/133

Paths for the docker-compose command are wrapped in quotes, which avoids problems if there are spaces in the path.

0xVolosnikov avatar May 08 '24 11:05 0xVolosnikov

@0xVolosnikov unfortunately that doesn't work on all systems. If I remember correctly having brackets won't work correctly through windows terminal

JackHamer09 avatar May 10 '24 19:05 JackHamer09

If I remember correctly having brackets won't work correctly through windows terminal

I never had any issues using quotes with Windows cmd. Anyway, I will search for best practices

UPD: seems like brackets also can be used with quotation marks.

0xVolosnikov avatar May 10 '24 20:05 0xVolosnikov

:tada: This PR is included in version 1.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Jul 09 '24 09:07 github-actions[bot]