PeepethClient icon indicating copy to clipboard operation
PeepethClient copied to clipboard

Add alamofire lib and rewrite network services

Open BaldyAsh opened this issue 6 years ago • 2 comments

Current behavior: Now it is native URLSession used to load some data and interact with APIs.

Expected behavior: Add Alamofire lib and rewrite URLSessions with Alamofire.

Suggested solution: You can add Alamofire lib via CocoaPods. All networking should be the separate class, that has functions with required parameters and do all the work by Alamofire.

Acceptance Criteria: The code is written in new branch named feature/Alamofire or something like that. The code implements the targets described above. The code can be merged into the develop branch without conflicts.

Required Skill: Participants needs to have a bit of experience in Swift software development.

BaldyAsh avatar Sep 29 '18 17:09 BaldyAsh

Started work on this via https://github.com/matterinc/PeepethClient/pull/25.

RommelTJ avatar Oct 19 '18 16:10 RommelTJ

PR #25 is merged, so I'll open a new PR in the future for the remaining work. Thanks @BaldyAsh!

RommelTJ avatar Oct 23 '18 16:10 RommelTJ