matter icon indicating copy to clipboard operation
matter copied to clipboard

`world:remove(...)` should not return anything

Open memorycode opened this issue 1 year ago • 0 comments

Current behavior

Calling world:remove(entityId, A) will try to return the instance of A that was removed.

Proposed improvement

The introduction of command buffering means that world:remove() is no longer guaranteed to return exactly what was removed. It is possible that there is a command in the buffer that alters the data.

Because of this, I believe that world:remove() should not return anything.

Additional context

I'm not sure how many people make use of this functionality but it should be considered deprecated for now.

memorycode avatar Jul 27 '24 02:07 memorycode