GitElephant icon indicating copy to clipboard operation
GitElephant copied to clipboard

Implement "reset" command (solution code included)

Open John-Schlick opened this issue 10 years ago • 6 comments

In order to implement the reset command, in Repository add the following use command: use GitElephant\Command\ResetCommand;

Now add the following function to Repository: /** * Reset this branch of the repository * * @param string $option usually --hard * @param tag $the tag to use as the reference for the reset * * @throws \RuntimeException * @throws \InvalidArgumentException * @throws \Symfony\Component\Process\Exception\RuntimeException * @return Repository */ public function reset($option = null, $tag = null) { $this->caller->execute(ResetCommand::getInstance()->reset($option, $tag));

    return $this;
}

and add the following file to the Command directory using hte name ResetCommand.php for the filename:

clearAll(); $this->addCommandName(self::GIT_RESET_COMMAND); // if there is an option add it. if (!is_null($option)) { $this->addCommandSubject($option); if (!is_null($tagOrCommit)) { $this->addCommandSubject2($tagOrCommit); } } return $this->getCommand(); } }

John-Schlick avatar Jun 18 '14 16:06 John-Schlick

Note: I'm happy to email any of this to you so that the formatting is kept. Drop me a line at [email protected] at any time.

John-Schlick avatar Jun 18 '14 16:06 John-Schlick

Thanks for taking your time...this could be a useful addition. Could you please send a pull request?

matteosister avatar Jun 18 '14 16:06 matteosister

How do I do that without the ability to make a branch in this repository? Like I said, I'm happy to mail you the updates. And in this case, it's a line and a function in Repository.php and a new file, so it's not like it's changes all over the codebase.

John-Schlick avatar Jun 18 '14 16:06 John-Schlick

Create a fork: https://help.github.com/articles/using-pull-requests

franzliedke avatar Jun 18 '14 16:06 franzliedke

https://help.github.com/articles/fork-a-repo

I cannot accept changes by email!

matteosister avatar Jun 18 '14 16:06 matteosister

There is now a pull request for this code: https://github.com/matteosister/GitElephant/pull/45

It is EXACTLY the code I proposed above.

John-Schlick avatar Jun 18 '14 18:06 John-Schlick