nice-json2csv icon indicating copy to clipboard operation
nice-json2csv copied to clipboard
verified publisher icon matteofigus

Add UTF-8 BOM support

Open fanweixiao opened this issue 11 years ago • 4 comments

I don't know if is right that adding a parameter called options, so I just send a PR with utf8 BOM support, .csv file should be away from encoding problems

Review on Reviewable

fanweixiao avatar Jul 21 '14 10:07 fanweixiao

Line 52: https://github.com/fanweixiao/nice-json2csv/commit/a3e4815e44663cc292ba17ee762c6c1544917b96#diff-1f8bcb5be7db7c497bfc0d8166c2bd70L52 should be fixing this. Can you explain a little better what are you trying to fix? What version of node and express are you using to get this problem?

matteofigus avatar Jul 21 '14 10:07 matteofigus

DIdn't got an answer about this question, so I'm closing this. In case you want to clarify, can you open another issue? Thanks.

matteofigus avatar Dec 03 '14 00:12 matteofigus

Sorry for did not reply immediately. I encountered problems when opening .csv file by Mac Office Excel in chinese, I added utf8 BOM to resolve this.

fanweixiao avatar Dec 03 '14 03:12 fanweixiao

It would be very helpful if you could include:

  • [ ] an input
  • [ ] the output for that input (with the error)
  • [ ] the expected output

In that case, I would be able to create a failing test and then work on the fix.

Thanks Matteo

matteofigus avatar Dec 03 '14 11:12 matteofigus