Matt Davis

Results 600 comments of Matt Davis

I understand what you are saying. The intent was never to remove the editable feature for local installs but I think the following things were in play: * Edge cases...

@edmorley I just opened a PR that modified that `is_editable` method that takes a pipfile entry to require editable be specified to be installed as editable. Sounds good, except there...

Just from glossing at it, it looks like there are tests asserting editable installs work, but not tests asserting anything about non-editable installs. Which I guess makes sense because the...

Sorry, I don't quite understand the issue -- could you elaborate/provide an example?

I wish I could tell you where you lost me, yes I have been using Python for 20 years -- so I have definitely run old scripts. Feel free to...

https://pipenv.pypa.io/en/latest/indexes.html#index-restricted-packages

I think `--all` could make sense, but one caution is I have plans to refactor the behavior of install: * `pipenv install` --> no longer locks all packages, just installs,...

@averypelle well if you want to take an initial attempt at the above two points, we should do that first in an isolated PR and then if that goes well,...

@glensc I am not sure I understand -- you call out the extras that you want `systemd` and so it tries to install them -- why not remove `extras=["systemd"]` from...

Ah I see what you mean now. `cysystemd = {version="==1.6.0", sys_platform="=='linux'"}` tries to resolve the sub-dependencies in current versions which could fail -- but if you convert it to a...