Matt Davis

Results 600 comments of Matt Davis

Actually I am pushing a fix to the ruff lint to main -- has nothing to do with this PR, but a news fragment would be good.

@rsilver23 Basically create a file in the news directory `5993.bugfix.rst` and explain the correction. Helpful to first run `pre-commit install` so that the linter will check your news file when...

@rjsilver oh hey -- there is a problem I just noticed, which is you are modifying the pip internals. We don't want to do that, if there was truly a...

@rjsilver I wonder if https://github.com/pypa/pip/issues/11050 is related?

@rsilver23 So we vendor in pip to pipenv and we have some patches that we apply after the fact. This feels like a case where pip itself would accept this...

That is great to hear -- we already regular vendor in pip, so I will close this PR as the plan is to go with the update in pip.

This is expected -- you want `pipenv upgrade `

I have gotten this feedback a-lot, but I didn't design the original implementation that basically re-locks everything during install. I did add the upgrade command. We can consider in a...

Just wondering, and its different from your virtualenv question, I'd have to dig more in that, but does this update to pythonfinder solve what you are seeing: https://github.com/pypa/pipenv/pull/5986

Well from my perspective, I use pipenv in windows all the time -- I recall such a similar issue in the past but I thought it was solved by upgrading...