react-helmet-example icon indicating copy to clipboard operation
react-helmet-example copied to clipboard

Published 20 hours ago • verified publisher icon mattdennewitz

Update to react-router@2

Open bguiz opened this issue 8 years ago • 7 comments

Initially left a comment here, but feel more appropriate to raise an issue here.

@doctyper It seems that several of us here are having issues. Just confirming that you are using it for server rendering as well?

If so, could you please update the react-helmet-example to use react-router@2 (it's currently using [email protected]): https://github.com/mattdennewitz/react-helmet-example/blob/master/package.json#L12

... and then I'd like to see what is done differently when rendering on the server: https://github.com/mattdennewitz/react-helmet-example/blob/master/server.js#L30-L48

CC @mattdennewitz

bguiz avatar Apr 07 '16 13:04 bguiz

Any updates?

aybmab avatar Sep 19 '16 19:09 aybmab

Sure, will take this on shortly.

mattdennewitz avatar Sep 19 '16 19:09 mattdennewitz

?

asiniy avatar Oct 29 '16 08:10 asiniy

Well take a look at this. @aybmab @bguiz React-helmet example app

vignestion avatar Nov 21 '16 10:11 vignestion

Not sure if they fixed it, but my team found a memory leak using react helmet. I ended up just building my own custom solution, which is actually pretty easy/straight-forward.

aybmab avatar Nov 21 '16 22:11 aybmab

@aybmab Interesting. Please open a ticket in react-helmet if you're still experiencing this leak.

doctyper avatar Nov 21 '16 23:11 doctyper

Anyone interested in implementing React Router 3 or 4?

mattdennewitz avatar Mar 01 '17 02:03 mattdennewitz