Matt Watson

Results 342 comments of Matt Watson

Will pull this in. Is there a specific prompt structure for vicuna?

Could you help make this repro a little more minimal to be able to triangulate what's going wrong? Do we know the minimum piece of code to trigger this error?...

@divyashreepathihalli would probably know re inference. If we don't support it we should add it. I don't see why we wouldn't want SAM 2, so SGTM to add. Are you...

Shoot! I think we actually might need to roll this back. `tensorflow` and `tensorflow-text` are indeed optional at import time, but really just as a power user feature. No task...

Instead I think we need the following for now. 1. `pip install keras-hub` should pull in `tensorflow-text` and `tensorflow` for now. We want a usable experience out of the box....

@jamesmyatt @Lundez yeah the issue moreso than tf-text is that *all* preprocessing is currently run through tf.data. So `tf.data` will feed your jax or torch program for a pure vision...

> What is the future of keras.application API? KerasHub, generally speaking, but keras.applications should will to work indefinitely! Not sure about this bug in particular, assigning to @divyashreepathihalli who wrote...

Thanks @miticollo. Agreed, this should move to the `keras` repo. Could we just have `models.layers` filter down to only return `Layer` and not `Operation`? That's what is used by the...

@miticollo good point. Perhaps? Still rubs me the wrong way that `model.layers` would return something that is not a layer. Users should be able to confidently call any layer method...