Matthew Costabile comments

Results 61 comments of


                                            Matthew Costabile

useColorSchemeVar should provide explicit color assistance/types and/or primer reexports primitives

@siddharthkp Would something like `useColorSchemeVars(colors => [partial` work here, to at least avoid leaking the primitives dependency into user code? Not sure how that might Play with consumer themes outside...

Active class name applied, even when `react-router` doesn't support it

Yes! I definitely agree it makes sense to remove this entirely - it seems weird for primer to handle this, instead of having users define their own. we already use...

Inaccurate type definitions for Button variant prop

I believe https://github.com/primer/react/pull/2445 fixes this

Enable add-to-project to add issues to a specific status / column in the project

> > I honestly forgot the workflows tab existed! Last I checked it was still under construction and thus disabled. Glad to see it can handle the use-case without much...

Rest Api from Cubejs gets mistaken as GraphQL when using both in one handler

> Hello there :) > > I was wondering whether you had any workaround for REST calls with a `query` in the body not getting caught/recognized by the graphQL MSW...

Rest Api from Cubejs gets mistaken as GraphQL when using both in one handler

@brantleyenglish et al In [version 2.0.9](https://github.com/mswjs/msw/releases/tag/v2.0.9) we shipped https://github.com/mswjs/msw/pull/1871 which should help differentiate graphql from rest requests and avoid the `console.error` discussed here. That version allows us to bail out...