ZipArchive icon indicating copy to clipboard operation
ZipArchive copied to clipboard

Retain Cycle cause by strong reference to delegate

Open raphaeloliveira opened this issue 10 years ago • 2 comments

Hey Matt, maybe I'm wrong but I think you should not have a strong reference to your delegate with the risk of causing a retain cycle.

https://github.com/mattconnolly/ZipArchive/blob/master/ZipArchive.h#L89

raphaeloliveira avatar Dec 18 '15 03:12 raphaeloliveira

I think you’re right. I haven’t looked at this project for a while now. Feel free to send a pull request.

-Matt

On 17 Dec 2015, at 7:26 PM, Raphael Oliveira [email protected] wrote:

Hey Matt, maybe I'm wrong but I think you should not have a strong reference to your delegate with the risk of causing a retain cycle

https://githubcom/mattconnolly/ZipArchive/blob/master/ZipArchiveh#L89

— Reply to this email directly or view it on GitHub https://github.com/mattconnolly/ZipArchive/issues/74.

mattconnolly avatar Dec 18 '15 04:12 mattconnolly

I'm getting following error (https://github.com/mattconnolly/ZipArchive/issues/66) when installing ZipArchive manually. Can you suggest me how to integrate it properly? I couldn't find any steps to do so. @mattconnolly @raphaeloliveira

hemang-azilen avatar Jan 22 '16 04:01 hemang-azilen