Matthew Olsson

Results 25 issues of Matthew Olsson

This can apply to optional, nullable parameters of platform types. This will cause the generator to generate the type as `Optional` rather than `JS::GCPtr`, allowing the implementation to differentiate between...

👀 pr-needs-review

In order to do so, we need to define animation composite ordering as well as some other misc helper methods. Work towards #21570

👀 pr-needs-review

As the title suggests, these commits implement the final behavior required before we can fully transition `StyleComputer` to Web Animations. Work towards #21570

👀 pr-needs-review

This PR will fully transition `StyleComputer` to use the new Web Animations framework, meaning that calls to `Element.animate` will now produce a visual result. I tried to break this down...

This PR fixes all but one issue seen in the demo I posted in [this comment](https://github.com/SerenityOS/serenity/pull/23311#issuecomment-1961601978). Here is a new demo: https://github.com/SerenityOS/serenity/assets/28801118/3ab9bb12-78d0-4bcf-9dff-ab1d45be1366

👀 pr-needs-review

I did this for the creation of the key frame set in `KeyframeEffect` for Web Animations, but forgot to do it in `StyleComputer` for `@keyframes` rules. Fixes #23367

👀 pr-needs-review

With this PR, we can interpolate between transforms whose functions don't match. For example: `translate(100px)` -> `scale(2) translateX(50px)`. New video of the demo: https://github.com/SerenityOS/serenity/assets/28801118/fa1079af-50cd-43f0-b0ad-a2b80c21a376 (I'm assuming the GPU painter doesn't...

👀 pr-needs-review

Consider the following snippet: ```html div { --some-var: -100px; animation: anim 1s infinite; } @keyframes anim { to { transform: translateX(calc(var(--some-var) * -1)); } } hello world ``` Before #23622,...

bug
has-repro

TODO: Test packet trigger changes to make sure there are no issues. Also make sure performance isn't impacted