Matt Caswell

All feedback addressed. Ping for reviews.

Closing since this is marked as resolved.

I've rebased this now that #19748 was merged and taken it out of draft. Ping for reviews!

All feedback above either addressed or otherwise responded to. Fixup commits pushed. Please take another look.

Cross compile CI failures appear to be due to a network glitch.

I'm not quite sure what you mean. The old `HMAC*` functions are deprecated and don't support providers/libctx at all. The new `EVP_Q_mac` function takes a libctx as its first parameter.

> Apologies: I was of the opinion that only HMAC_* functions and not HMAC() are deprecated and thus used HMAC() Oh! You are absolutely right. I had completely forgotten that...

> On the other hand it is kind of implicit that a function that does not have libctx argument or any other context argument, cannot really use non-default libctx. Right...

Yes, this is supposed to work. Looks like a bug.

Maybe @amatyuko-intc might be able to help out here...