Matt Caswell comments

Results 503 comments of


                                            Matt Caswell

Old vulnerabilites in OpenSSL 3?

Version 1.1.1l was released on 24th August 2021. > I don't think there is any other version on that server. If there is truly no other version on that server,...

Adding signature algorithms via provider interface

IMO external testing should only ever be supplementary. We should have our own tests that we can easily extend and modify as required over time. For example, lets say we...

Adding signature algorithms via provider interface

The test policy says this: > All Pull Requests adding new functionality to the applications, libraries, providers or engines must include suitable tests. But it also says: > It is...

Adding signature algorithms via provider interface

Oh....this is a significant feature, so it should have an entry in CHANGES.md

exclude all COFF binaries from "symbol_presence" test-2

Try this: ```` perl -e 'print "$^O\n"' ````

ci: don't test the master FIPS provider against a 3.0 build

> We decided to do these tests for a reason, Disabling them after a such a short time seems like a bad idea. Agreed. But I also agree that we...

threads_pthread.c:48: error: `PTHREAD_MUTEX_RECURSIVE' undeclared

That's quite strange. I assume what you posted was the extent of the errors...there weren't any others? From the error message it seems perfectly happy with the function `pthread_mutexattr_settype` just...

threads_pthread.c:48: error: `PTHREAD_MUTEX_RECURSIVE' undeclared

Seems reasonable. Want to create a PR for that?

Removal of Whirlpool hash algorithm

I see no reason to remove it at this stage.

OpenSSL Assertion Error While generating Ciphertext in v1.02

There are some curious things about your question. Firstly you say you are trying to use SM3, but OpenSSL 1.0.2u does not support SM3. You don't mention hmac in your...