libphonenumber icon indicating copy to clipboard operation
libphonenumber copied to clipboard

Add Windows support

Open abrkn opened this issue 10 years ago • 3 comments

abrkn avatar Oct 31 '13 10:10 abrkn

Can you paste me a log of you running "npm test" on a clean checkout indicating the problem on Windows? I am not able to see any problem with the package as-is.

If the problem does not reproduce with current tests, please add a test to illustrate it.

mattbornski avatar Feb 22 '14 19:02 mattbornski

@jksdua @justindujardin @abrkn Is there any chance you guys can hash out the proper way to support Windows? It sounds as if different syntax is supported on different node or package versions.

I previously had an appveyor account set up for testing this, but it appears to have mysteriously vanished. I do not have easy access to any Windows boxes to effectively judge these contributions.

mattbornski avatar Jul 22 '14 15:07 mattbornski

@bryankreitlow made these changes, I just submitted the request.

justindujardin avatar Jul 22 '14 15:07 justindujardin