autoclose-html icon indicating copy to clipboard operation
autoclose-html copied to clipboard

Not working with JSX by default

Open jmgunter opened this issue 7 years ago • 3 comments

I love this package, thanks so much for building! I hope the below comment helps anyone else with the same issue:

I wasn't able to get auto close to work with JSX files until modifying the atom key map file to include:

'atom-text-editor': '>': 'autoclose-html:close-and-complete'

jmgunter avatar Jun 02 '17 22:06 jmgunter

atom-text-editor[data-grammar~="jsx"] would be more appropriate I think

phaux avatar Jun 27 '17 07:06 phaux

Might this be related to the "no more grammars" commits from 0.22?

https://github.com/mattberkowitz/autoclose-html/commit/73cdb1292978c3b491ef5adc24bb108001aebce3

If we need to re-add each of the grammars by assigning a "new" keyboard shortcut that mirrors the default one I almost wonder if this is a superior solution to the grammar list from before 0.22…

mpacer avatar Sep 11 '17 23:09 mpacer

I love this package, thanks so much for building! I hope the below comment helps anyone else with the same issue:

I wasn't able to get auto close to work with JSX files until modifying the atom key map file to include:

'atom-text-editor': '>': 'autoclose-html:close-and-complete'

Thanks, I was going crazy because I couldn't figure out why my tags wouldn't automatically close in JSX files anymore. I think this behaviour is really counter intuitive, at least as long as it's not documented or has a corresponding setting of some kind.

itscursedphil avatar Nov 01 '18 14:11 itscursedphil